chore: revert SchedulerLike interface changes #5268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwonoj
approved these changes
Jan 25, 2020
kwonoj
pushed a commit
to kwonoj/rxjs
that referenced
this pull request
Feb 5, 2020
* chore: revert SchedulerLike interface changes * chore: kick CI ... again ... wtf?
martinsik
pushed a commit
to martinsik/rxjs
that referenced
this pull request
Feb 15, 2020
* chore: revert SchedulerLike interface changes * chore: kick CI ... again ... wtf?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR reverts the changes made to the
SchedulerLikeinterface. As discussed in the core-team Slack channel - with @MichaelJamesParsons - the changes broke user-land schedulers. (Angular Zone-related schedulers are not uncommon.)Although the typing of the
SchedulerLikeinterface in arguably incorrect, it might be best to leave it as-is and delay any changes to the scheduler infrastructure until version 8.The reversion has necessitated the liberal use of
as anyassertions, as all of the dispatch/work functions assume astatethat is notundefined. This problem was hidden until thestricttypescript option was enabled. I did try a few other approaches - including using a conditional type instead of theas anyassertion - but they didn't work out.Related issue: None